Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: make videos bigger #4980

Merged
merged 2 commits into from
Oct 10, 2023
Merged

docs: make videos bigger #4980

merged 2 commits into from
Oct 10, 2023

Conversation

thomasheartman
Copy link
Contributor

@thomasheartman thomasheartman commented Oct 10, 2023 •
edited

This PR changes the VideoContent component to:

  • remove the extra text; keeps only videos
  • makes videos take up the full article width
  • multiple videos stack vertically (this may or may not be the best way to handle it, but we don't have any instances of using multiple videos as of right now, so we shouldn't touch this until we do).

By chance, it also removes a lot of trailing whitespace in files. I suggest checking out the diff with whitespace hidden.

Before (single video):
image

Before (if there were multiple videos):
image

After (single video):
image

After (if there are multiple videos):
image

@vercel
Copy link

vercel bot commented Oct 10, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2023 8:50am
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2023 8:50am

@thomasheartman thomasheartman enabled auto-merge (squash) October 10, 2023 08:54
sebastian-bury
sebastian-bury approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@sebastian-bury sebastian-bury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@thomasheartman thomasheartman merged commit fa4d6b2 into main Oct 10, 2023
15 checks passed
@thomasheartman thomasheartman deleted the docs/bigger-videos branch October 10, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastian-bury sebastian-bury sebastian-bury approved these changes

@dgorton dgorton Awaiting requested review from dgorton

@nicolaesocaciu nicolaesocaciu Awaiting requested review from nicolaesocaciu

@daveleek daveleek Awaiting requested review from daveleek

Assignees

@thomasheartman thomasheartman

Labels
None yet
Projects
Issues and PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thomasheartman @sebastian-bury