Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make invite link more visible #4984

Merged
merged 10 commits into from
Oct 11, 2023
Merged

feat: make invite link more visible #4984

merged 10 commits into from
Oct 11, 2023

Conversation

sjaanus
Copy link
Contributor

@sjaanus sjaanus commented Oct 10, 2023

  1. This is shortcut to invite more people to unleash
  2. This is only visible to admins
  3. Reusing the existing component

image
image

@vercel
Copy link

vercel bot commented Oct 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2023 11:09am
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2023 11:09am

@sjaanus sjaanus changed the title New invite link feat: make invite link more visible Oct 10, 2023
Copy link
Contributor

@FredrikOseberg FredrikOseberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks nice, added a few minor comments.

However, on a medium sized window the popover will overflow the X axis and push the content out of bounds:

Skjermbilde 2023-10-11 kl  12 48 26

Comment on lines 65 to 71
mb: {
xs: 1,
md: 0,
},
display: 'flex',
justifyContent: 'center',
flexDirection: 'column',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be styled component

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Comment on lines 113 to 120
sx={{
display: 'flex',
justifyContent: {
xs: 'center',
md: 'flex-end',
},
alignItems: 'center',
flexGrow: 1,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be styled component

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@sjaanus
Copy link
Contributor Author

sjaanus commented Oct 11, 2023

Overall this looks nice, added a few minor comments.

However, on a medium sized window the popover will overflow the X axis and push the content out of bounds:

Skjermbilde 2023-10-11 kl 12 48 26

Now it cant be pushed out of bounds.

Copy link
Contributor

@FredrikOseberg FredrikOseberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjaanus sjaanus merged commit 6928633 into main Oct 11, 2023
16 checks passed
@sjaanus sjaanus deleted the new-invite-link branch October 11, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants