Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: re-order message banners #4995

Merged
merged 1 commit into from
Oct 11, 2023
Merged

feat: re-order message banners #4995

merged 1 commit into from
Oct 11, 2023

Conversation

nunogois
Copy link
Member

@nunogois nunogois commented Oct 11, 2023

https://linear.app/unleash/issue/2-1494/re-order-message-banners

  • Re-orders message banners to fit into this logic:
  1. Maintenance banner
  2. External message banner(s) - Most likely coming from Unleash
  3. Internal message banner(s)
  • Renames the feature flag to better reflect the feature behavior;
  • Lays a basic skeleton structure for this new feature;

@vercel
Copy link

vercel bot commented Oct 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview Oct 11, 2023 10:33am
1 Ignored Deployment
Name Status Preview Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Oct 11, 2023 10:33am

Copy link
Contributor

@daveleek daveleek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nunogois nunogois merged commit 65f4241 into main Oct 11, 2023
17 checks passed
@nunogois nunogois deleted the feat-reorder-message-banners branch October 11, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants