fix: disable all environments when reviving a feature #4999
Conversation
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
| @@ -362,6 +362,11 @@ export default class FeatureToggleStore implements IFeatureToggleStore { | |||
| .where({ name }) | |||
| .update({ archived_at: null }) | |||
| .returning(FEATURE_COLUMNS); | |||
|
|
|||
| await this.db(FEATURE_ENVIRONMENTS_TABLE) | |||
There was a problem hiding this comment.
I think this should be part of the archive method, not revive.
Also I'm not sure whether it should be done at the store level or service level.
Finally since we have write operations on the write model we need to wrap the whole service method in a transaction. If you decide to do it as part of archive and bulk archive then I'd wrap it in a tx in a controller doing the archive.
There was a problem hiding this comment.
The problem right now with doing it at archive is that already archived features will not get it - We could have a migration that disables the environments for already archived features, but I would rather not.
There was a problem hiding this comment.
Good point on the transaction wrapping
There was a problem hiding this comment.
so maybe both? in the long term it makes more sense to me to do it as part of archive. We'll probably also clean the dependencies in the archive so having one "cleanup" location would be nice.
what's the problem with a db migration?
There was a problem hiding this comment.
Only problem I see with the migration is that it will not be reversible
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
|
Moved the functionality to the service layer and wrapped in |
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
andreas-unleash
deleted the
feat/reviving-a-feature-should-disable-all-envs
branch
Disable all environments when reviving a feature
Closes # SR-93