Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect archive feature #5003

Merged
merged 6 commits into from
Oct 12, 2023
Merged

Protect archive feature #5003

merged 6 commits into from
Oct 12, 2023

Conversation

kwasniew
Copy link
Contributor

@kwasniew kwasniew commented Oct 11, 2023

About the changes

Introduced protected archive/bulk archive operations that take change requests into account

Important files

Discussion points

@vercel
Copy link

vercel bot commented Oct 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 12, 2023 6:37am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ⬜️ Ignored (Inspect) Visit Preview Oct 12, 2023 6:37am

user: User,
projectId: string,
): Promise<void> {
this.stopWhenChangeRequestsEnabled(projectId, undefined, user);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing await?

@kwasniew kwasniew merged commit cfcf9de into main Oct 12, 2023
9 checks passed
@kwasniew kwasniew deleted the protect-archive-feature branch October 12, 2023 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants