chore: split interfaces for import and export #5004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
kwasniew
approved these changes
Oct 12, 2023
src/lib/types/services.ts
Outdated
| exportImportService: ExportImportService; | ||
| exportImportServiceV2: WithTransactional<ExportImportService>; | ||
| exportService: IExportService; | ||
| importService: WithTransactional<ExportImportService>; |
There was a problem hiding this comment.
Why not IExportService after you split them?
There was a problem hiding this comment.
I believe you mean, why not IImportService, right? Now, export doesn't have to be transactional and we can use the same and we only need import to be transactional
There was a problem hiding this comment.
Let me know if 6950fc1 is what you're expecting ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
This splits the interfaces for import and export, especially because the import functionality has to be replaced in enterprise repo.
This is a breaking change because of the service renames, but I'll have the PR for the other repository ready so we reduce the time to fix. I intentionally avoided doing it backward compatible because of time.