feat: dynamic icons by adding material symbols font #5008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
sighphyre
reviewed
Oct 12, 2023
frontend/src/themes/dark-theme.ts
Outdated
| @@ -617,5 +617,12 @@ export default createTheme({ | |||
| }), | |||
| }, | |||
| }, | |||
|
|
|||
| // Default Icon to Material Symbols Outlined font | |||
There was a problem hiding this comment.
Very personal opinion but this comment doesn't help me much. The code suggests this is a default prop for material-symbols-outlined, the comment just reiterates that
Totally fine for it to stick around
There was a problem hiding this comment.
Fair point, seems redundant. I'll yeet it!
sighphyre
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/unleash/issue/2-1502/add-support-for-custom-dynamic-icons-mui-icon-component
Adds support for custom dynamic icons by adding the Material Symbols Outlined font and setting the MUI Icon component base class. See: https://mui.com/material-ui/icons/#icon-font-icons
Message banner use case: This will not only enable us to set custom icons for external message banners, but will also let users configure their desired icon from the set of options in the font.