Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: message banner internal link assumption #5011

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

nunogois
Copy link
Member

https://linear.app/unleash/issue/2-1504/fix-message-banner-internal-link-assumption

Fixes the internal link assumption in message banner to .startsWith('/') - Any other links will be treated as external (normal href).

@vercel
Copy link

vercel bot commented Oct 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 12, 2023 11:12am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Oct 12, 2023 11:12am

@nunogois nunogois merged commit d30e059 into main Oct 12, 2023
16 checks passed
@nunogois nunogois deleted the fix-message-banner-internal-assumption branch October 12, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants