feat: add hasStrategies and hasEnabledStrategies on feature environments #5012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Tymek
requested review from
sjaanus,
FredrikOseberg,
sighphyre and
andreas-unleash
...nent/project/Project/ProjectFeatureToggles/FeatureToggleSwitch/LegacyFeatureToggleSwitch.tsx
Show resolved
Hide resolved
...mponent/project/Project/ProjectFeatureToggles/FeatureToggleSwitch/useFeatureToggleSwitch.tsx
Show resolved
Hide resolved
...nent/project/Project/ProjectFeatureToggles/FeatureToggleSwitch/LegacyFeatureToggleSwitch.tsx
Show resolved
Hide resolved
...nent/project/Project/ProjectFeatureToggles/FeatureToggleSwitch/LegacyFeatureToggleSwitch.tsx
Show resolved
Hide resolved
Comment on lines
+74
to
+82
| hasStrategies: { | ||
| type: 'boolean', | ||
| description: 'Whether the feature has any strategies defined.', | ||
| }, | ||
| hasEnabledStrategies: { | ||
| type: 'boolean', | ||
| description: | ||
| 'Whether the feature has any enabled strategies defined.', | ||
| }, |
There was a problem hiding this comment.
Where are the tests verifying that these are part of the payload?
Tymek
commented
Oct 19, 2023
| isChangeRequestEnabled: boolean, | ||
| refetch: () => void, | ||
| onFeatureToggleSwitch: ReturnType<UseFeatureToggleSwitchType>['onToggle'], | ||
| ) => |
There was a problem hiding this comment.
simplify component factory arguments type
Tymek
commented
Oct 19, 2023
| hasStrategies?: boolean; | ||
| hasEnabledStrategies?: boolean; | ||
| isChangeRequestEnabled?: boolean; | ||
| onRollback?: () => void; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Trying to fetch all details about the feature needed for Project Overview, to remove
useFeaturefromFeatureToggleSwitch.useFeature- prevent fetching for every rowonToggle- middleware pattern on action