Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error icon, add only relevant variants #5014

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

nunogois
Copy link
Member

@nunogois nunogois commented Oct 12, 2023

https://linear.app/unleash/issue/2-1508/fix-message-banner-error-variant-icon

After aligning with @nicolaesocaciu, we fixed the error variant icon and removed irrelevant message variants for now.

Co-authored-by: Nicolae nicolae@getunleash.ai

@vercel
Copy link

vercel bot commented Oct 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview Oct 12, 2023 2:31pm
1 Ignored Deployment
Name Status Preview Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Oct 12, 2023 2:31pm

Copy link
Contributor

@nicolaesocaciu nicolaesocaciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nunogois nunogois merged commit 2adfb7b into main Oct 12, 2023
16 checks passed
@nunogois nunogois deleted the fix-message-banner-variants branch October 12, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants