feat: make maintenance-related 503s more intuitive #5018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
| if (propagateErrors) { | ||
| if (maintenanceMode) { | ||
| throw new Error( | ||
| 'Operation unavailable: Maintenance mode is enabled', |
There was a problem hiding this comment.
Should we set this message in the backend instead? If you're using an API I believe you'd like to know as well...
There was a problem hiding this comment.
Fair point. How about this? d9ea8a6
There was a problem hiding this comment.
Nice, should we just get the message sent from the backend?
There was a problem hiding this comment.
I mean, that way we only change it on one side
There was a problem hiding this comment.
How about this then? a1323c9
nunogois
force-pushed
the
feat-better-maintenance-503s
branch
from
a1323c9
to
5debc4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes maintenance-related 503s more intuitive on our UI by mentioning that maintenance banner is currently enabled.