feat: validate archive dependent features #5019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
kwasniew
commented
Oct 13, 2023
| @@ -16,6 +16,11 @@ export const createKnexTransactionStarter = ( | |||
| function transaction<T>( | |||
| scope: (trx: KnexTransaction) => void | Promise<T>, | |||
| ) { | |||
| if (!knex) { | |||
| console.warn( | |||
There was a problem hiding this comment.
very often we get a weird error in tests that db is not provided. This will shorten debugging time.
kwasniew
commented
Oct 13, 2023
| }, | ||
| }, | ||
| }); | ||
| db.rawDatabase, |
There was a problem hiding this comment.
added console.log in transactional code to indicate that this part is missing.
kwasniew
commented
Oct 13, 2023
| @@ -91,7 +90,7 @@ export default class DependentFeaturesController extends Controller { | |||
| permission: UPDATE_FEATURE_DEPENDENCY, | |||
| middleware: [ | |||
| openApiService.validPath({ | |||
| tags: ['Features'], | |||
| tags: ['Dependencies'], | |||
There was a problem hiding this comment.
added new category for dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Endpoint for validating if a group of features can be archived. The validation result is a list of parents that would orphan some child features. If the list is empty it means we can proceed.
It will be used in the next PR that will disable the archive button when archive operation leaves some orphan features.
Important files
Discussion points