feat: warn about sdk update with feature dependencies #5065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
thomasheartman
approved these changes
Oct 17, 2023
| target='_blank' | ||
| rel='noreferrer' | ||
| > | ||
| Read more |
There was a problem hiding this comment.
This link text doesn't say anything about what the link points to. It should be possible to understand what a link points to without any context. Can we do something like this instead?
Suggested change
| Read more | |
| Client SDK support for feature dependencies |
Potentially preface the link (outside of the a tag) with "Read more about"?
| @@ -189,6 +190,8 @@ export const AddDependencyDialogue = ({ | |||
| secondaryButtonText='Cancel' | |||
| > | |||
| <Box> | |||
| <DependenciesUpgradeAlert/> | |||
| <br /> | |||
There was a problem hiding this comment.
Why do we use the br tag? Shouldn't spacing between elements be handled by styling?
There was a problem hiding this comment.
copied from existing patterns but agree that styled components is more elegant. Adjusting it now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Important files
Discussion points