Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: introduce type to prevent potential issues #5066

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

gastonfournier
Copy link
Contributor

@gastonfournier gastonfournier commented Oct 17, 2023

About the changes

This small improvement aims to help developers when instantiating services. They need to be constructed without injecting services or stores created elsewhere so they can be bound to the same transactional scope.

This suggests that you need to create the services and stores on your own

@vercel
Copy link

vercel bot commented Oct 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Oct 17, 2023 10:16am
unleash-monorepo-frontend ⬜️ Ignored (Inspect) Oct 17, 2023 10:16am

Copy link
Member

@nunogois nunogois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gastonfournier gastonfournier merged commit db04a1e into main Oct 17, 2023
10 checks passed
@gastonfournier gastonfournier deleted the add-deferred-type branch October 17, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants