feat: dependent features use new transaction mechanism #5073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
gastonfournier
approved these changes
Oct 17, 2023
| : createFakeDependentFeaturesService(config); | ||
| const transactionalDependentFeaturesService = (txDb: Knex.Transaction) => | ||
| createDependentFeaturesService(txDb, config); | ||
| const transactionalDependentFeaturesService = db |
There was a problem hiding this comment.
Do you need both dependentFeatureService and transactionalDependentFeaturesService? I think you can just
const dependentFeaturesService = transactionalDependentFeaturesServiceThere was a problem hiding this comment.
you're right, we don't need both.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Dependent features use new transaction mechanism
Added missing transactions in delete dependencies operations.
Important files
Discussion points