fix: force deletion of archived toggles when deleting a project #5080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sjaanus
requested changes
Oct 18, 2023
sjaanus
approved these changes
Oct 18, 2023
sighphyre
force-pushed
the
fix/clean-up-archived-toggles-when-deleting-project
branch
from
e1e4443
to
a8361f2
Compare
sighphyre
force-pushed
the
fix/clean-up-archived-toggles-when-deleting-project
branch
from
a8361f2
to
a283f31
Compare
sighphyre
deleted the
fix/clean-up-archived-toggles-when-deleting-project
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This forces the project service to delete archived toggles when a project is deleted. Previously, when deleting a project, you were blocked if you had one or more active toggles but once they're archived the project can be deleted. Those archived toggles would persist indefinitely and when a new project was created that matched the old project name, they would immediately be bound to that project in an archived state. This was really confusing for users across teams, since they could create a project that someone else had created, used and then deleted and they would get a bunch of toggles in their project that they had never touched