feat: ensure at least one owner on remove user/group access #5085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
gastonfournier
force-pushed
the
ensure-projects-have-owners
branch
from
858641c
to
e6c4f3c
Compare
gastonfournier
changed the title
sighphyre
reviewed
Oct 19, 2023
sighphyre
reviewed
Oct 19, 2023
gastonfournier
commented
Oct 19, 2023
| @@ -491,31 +499,6 @@ test('should remove user from the project', async () => { | |||
| expect(memberUsers).toHaveLength(0); | |||
| }); | |||
|
|
|||
| test('should not remove user from the project', async () => { | |||
There was a problem hiding this comment.
Moved to line 1006
gastonfournier
force-pushed
the
ensure-projects-have-owners
branch
from
d9de330
to
b5b4fb9
Compare
kwasniew
reviewed
Nov 21, 2023
| @@ -508,6 +500,11 @@ export default class ProjectService { | |||
| userId, | |||
| ); | |||
|
|
|||
| const ownerRole = await this.accessService.getRoleByName( | |||
| RoleName.OWNER, | |||
There was a problem hiding this comment.
this seems to be a bug since we're getting a role for the owner not the user we're deleting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
This makes sure that projects have at least one owner, either a group or a user. This is to prevent accidentally losing access to a project.
We check this when removing a user/group or when changing the role of a user/group
Note: We can still leave a group empty as the only owner of the project, but that's okay because we can still add more users to the group