Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove storybook #5091

Merged
merged 1 commit into from
Oct 19, 2023
Merged

chore: remove storybook #5091

merged 1 commit into from
Oct 19, 2023

Conversation

sjaanus
Copy link
Contributor

@sjaanus sjaanus commented Oct 19, 2023

We have vulnerability from storybook https://github.com/Unleash/unleash/security/dependabot/89.
Talked with Thomas that we are not actually using it, so removing it.

@vercel
Copy link

vercel bot commented Oct 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 19, 2023 7:01am
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 19, 2023 7:01am

Copy link
Contributor

@thomasheartman thomasheartman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh, that's a nice ratio! But yeah, this looks great to me; thanks for sorting it out 🙌🏼

@@ -215,6 +215,6 @@
},
"lint-staged": {
"*.{js,ts}": ["biome check --apply"],
"*.json": ["biome format --write"]
"*.json": ["biome format --write --no-errors-on-unmatched"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, this is a nice catch! I've been wondering why I've been getting that error sometimes 😄

@sjaanus sjaanus merged commit f3a7bfd into main Oct 19, 2023
17 of 18 checks passed
@sjaanus sjaanus deleted the remove-storybook branch October 19, 2023 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants