Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: detect grandchild dependency #5094

Merged
merged 2 commits into from
Oct 19, 2023
Merged

Conversation

kwasniew
Copy link
Contributor

@kwasniew kwasniew commented Oct 19, 2023

About the changes

Detect when you have GRAND_PARENT - PARENT dependency and you try to add GRAND_PARENT - PARENT - CHILD

Previously we only had grandparent detection, now we add grandchild detection.

Important files

Discussion points

@vercel
Copy link

vercel bot commented Oct 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Oct 19, 2023 9:56am
unleash-monorepo-frontend ⬜️ Ignored (Inspect) Visit Preview Oct 19, 2023 9:56am

Copy link
Contributor

@FredrikOseberg FredrikOseberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kwasniew kwasniew merged commit de237d8 into main Oct 19, 2023
8 checks passed
@kwasniew kwasniew deleted the detect-grandchild-dependency branch October 19, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants