feat: show warning about dependencies removed on archive #5104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kwasniew
commented
Oct 19, 2023
| @@ -38,7 +38,10 @@ const setupArchiveValidation = (orphanParents: string[]) => { | |||
| testServerRoute( | |||
| server, | |||
| '/api/admin/projects/projectId/archive/validate', | |||
| orphanParents, | |||
| { | |||
There was a problem hiding this comment.
new structure returned from backend
kwasniew
commented
Oct 19, 2023
| @@ -144,6 +153,11 @@ test('Show error message when multiple parents of orphaned children are archived | |||
| await screen.findByText( | |||
| 'have child features that depend on them and are not part of the archive operation. These parent features can not be archived:', | |||
| ); | |||
| expect( | |||
There was a problem hiding this comment.
we should not show the warning if there's already an error about orphaned children. Error and warning would confuse people
kwasniew
commented
Oct 19, 2023
| featureNames, | ||
| ); | ||
| return { | ||
| hasDeletedDependencies, |
There was a problem hiding this comment.
added this to our archive validation. It now indicates if any dependencies will be removed
FredrikOseberg
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Users should know that dependencies will be removed
The most important change is that our read model returns:
which covers our previous use case (parent that would orphan child features) and our new use case indicating if any dependencies will be deleted as part of the archive operation.
Important files
Discussion points