feat: add job that cleans last seen every 24 hours #5114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
FredrikOseberg
commented
Oct 20, 2023
| await lastSeenService.store(); | ||
|
|
||
| // We have no method to get these from the last seen service or any other service or store | ||
| let stored = await db.rawDatabase.raw( |
There was a problem hiding this comment.
We have no get method for this table
kwasniew
reviewed
Oct 23, 2023
src/lib/services/index.ts
Outdated
| if (flagResolver.isEnabled('useLastSeenRefactor')) { | ||
| schedulerService.schedule( | ||
| lastSeenService.cleanLastSeen.bind(lastSeenService), | ||
| hoursToMilliseconds(24), |
There was a problem hiding this comment.
Let's change to 1h so that we can run it outside of the app startup
kwasniew
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a cleanup job that removes unknown feature flags from last_seen_at_metrics table every 24 hours since we no longer have a foreign key on the name column in the features table.