Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: one of our deps breaks on node 21 #5122

Merged
merged 1 commit into from
Oct 23, 2023
Merged

fix: one of our deps breaks on node 21 #5122

merged 1 commit into from
Oct 23, 2023

Conversation

kwasniew
Copy link
Contributor

@kwasniew kwasniew commented Oct 23, 2023

About the changes

In heroku our build breaks with:

   [build:frontend] [vite:css] Preprocessor dependency "sass" failed to load:
   [build:frontend] Cannot read properties of undefined (reading 'indexOf')

Root cause analysis:

  • heroku installs node 21 which doesn't work with the sass dependency compiled from dart to js

More: https://stackoverflow.com/questions/77314799/vitecss-preprocessor-dependency-sass-failed-to-load-cannot-read-propertie

Important files

Discussion points

@vercel
Copy link

vercel bot commented Oct 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Oct 23, 2023 9:27am
unleash-monorepo-frontend ⬜️ Ignored (Inspect) Visit Preview Oct 23, 2023 9:27am

@kwasniew kwasniew merged commit 8c97847 into main Oct 23, 2023
10 checks passed
@kwasniew kwasniew deleted the fix-heroku-build branch October 23, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants