Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: silent migration test #5131

Merged
merged 1 commit into from
Oct 23, 2023
Merged

test: silent migration test #5131

merged 1 commit into from
Oct 23, 2023

Conversation

kwasniew
Copy link
Contributor

@kwasniew kwasniew commented Oct 23, 2023

About the changes

Our test logs were obscured by the migration test doing extensive console.log.

This PR applies the same trick as our production db migrator (copied code from the migrator.ts):

  • sets log level to error
  • removes verbose mode set by some IDEs e.g. WebStorm

Important files

Discussion points

@vercel
Copy link

vercel bot commented Oct 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Oct 23, 2023 3:04pm
unleash-monorepo-frontend ⬜️ Ignored (Inspect) Oct 23, 2023 3:04pm

Copy link
Contributor

@gastonfournier gastonfournier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This was on the back of my head for a while! 🙌

@kwasniew kwasniew merged commit ab390db into main Oct 23, 2023
10 checks passed
@kwasniew kwasniew deleted the silent-db-migration-test branch October 23, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants