Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: banner modal #5132

Merged
merged 2 commits into from
Oct 24, 2023
Merged

feat: banner modal #5132

merged 2 commits into from
Oct 24, 2023

Conversation

nunogois
Copy link
Member

https://linear.app/unleash/issue/2-1548/ui-create-banner-newedit-modal

Adds a new banner modal (and form) that allows admins to create and edit banners.
Also adds a new FormSwitch common component that may be helpful in different situations where we need a switch on a form.

image

@vercel
Copy link

vercel bot commented Oct 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2023 3:25pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Oct 23, 2023 3:25pm

Copy link
Contributor

@gastonfournier gastonfournier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -234,11 +235,11 @@ export const BannersTable = () => {
/>
}
/>
{/* <BannerModal
<BannerModal
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!
image

@nunogois nunogois merged commit 3ca22c7 into main Oct 24, 2023
16 checks passed
@nunogois nunogois deleted the feat-banner-modal branch October 24, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants