Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: slight clean up after GAing multiple roles #5133

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

nunogois
Copy link
Member

Follow up cleanup to #5109
Based on #5109 (review)

@nunogois nunogois requested a review from chriswk October 24, 2023 07:16
@vercel
Copy link

vercel bot commented Oct 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2023 7:17am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Oct 24, 2023 7:17am

Copy link
Contributor

@chriswk chriswk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I thought I caught all of these. :)

@nunogois nunogois merged commit 90296be into main Oct 24, 2023
16 checks passed
@nunogois nunogois deleted the refactor-multiple-roles-cleanup-after-ga branch October 24, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants