feat: filter features by type #5160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
kwasniew
commented
Oct 26, 2023
| in: 'query', | ||
| }, | ||
| ] as const; | ||
|
|
||
| export type FeatureSearchQueryParameters = FromQueryParams< | ||
| typeof featureSearchQueryParameters | ||
| export type FeatureSearchQueryParameters = Partial< |
There was a problem hiding this comment.
All query params are optional
kwasniew
commented
Oct 26, 2023
| @@ -19,6 +19,14 @@ export interface FeatureConfigurationClient { | |||
| variants: IVariant[]; | |||
| dependencies?: IDependency[]; | |||
| } | |||
|
|
|||
| export interface IFeatureSearchParams { | |||
There was a problem hiding this comment.
This type mixes data from query params and userId so decided to create a custom type that is used by store and service
kwasniew
commented
Oct 26, 2023
| @@ -542,6 +542,9 @@ class FeatureStrategiesStore implements IFeatureStrategiesStore { | |||
| .whereILike('features.name', `%${queryString}%`) | |||
| .orWhereIn('features.name', tagQuery); | |||
| } | |||
| if (type) { | |||
| query = query.whereIn('features.type', type); | |||
There was a problem hiding this comment.
this is the whole query logic added by this PR
kwasniew
commented
Oct 26, 2023
| await app.createFeature({ name: 'my_feature_a', type: 'release' }); | ||
| await app.createFeature({ name: 'my_feature_b', type: 'experimental' }); | ||
|
|
||
| const { body } = await filterFeaturesByType([ |
There was a problem hiding this comment.
showing one matching type and one that is not used
kwasniew
commented
Oct 26, 2023
| @@ -71,10 +71,13 @@ export default class FeatureSearchController extends Controller { | |||
| res: Response, | |||
| ): Promise<void> { | |||
| if (this.config.flagResolver.isEnabled('featureSearchAPI')) { | |||
| const { query = '', projectId = '' } = req.query; | |||
| const { query, projectId, type } = req.query; | |||
There was a problem hiding this comment.
no need for default values
kwasniew
commented
Oct 26, 2023
| expectedCode = 200, | ||
| ) => { | ||
| return app.request | ||
| .get(`/api/admin/search/features?query=${query}&projectId=${projectId}`) | ||
| .expect(expectedCode); | ||
| }; | ||
|
|
||
| const filterFeaturesByType = async (types: string[], expectedCode = 200) => { | ||
| const typeParams = types.map((type) => `type[]=${type}`).join('&'); |
There was a problem hiding this comment.
this is how we handle array in query params
andreas-unleash
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Can filter search results by one or many feature types.
Based on this example it's easy to add other filter types. The important part of research here was handling multiple values in query params.
Important files
Discussion points