Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to not write feature definition to file system and use in memory cache #7099

Open
debangob opened this issue May 21, 2024 · 4 comments

Comments

@debangob
Copy link

Describe the feature request

We have cases where unleash SDK can be run from self hosted apps and as a result can leak PII information that is stored in feature definitions( context, strategies etc). Those cases are preventing us from using unleash in the product. Please consider providing a solution or using in memory caching, instead of writing to file system.

Background

No response

Solution suggestions

In memory caching for (.net) SDKs

@ivarconr
Copy link
Member

I think it make sense to be able to disable writing to file. Other SDKs (Java, Node) allow you to inject a custom file handler, and you can do a noop). Is this not possible on .net @daveleek ?

@sighphyre
Copy link
Member

I think it make sense to be able to disable writing to file. Other SDKs (Java, Node) allow you to inject a custom file handler, and you can do a noop). Is this not possible on .net @daveleek ?

Not on this SDK. The backup code is currently newed up directly rather than injected and there's no external hook to override that. Probably not hard to change just needs a bit of time to do so

@ivarconr
Copy link
Member

Could we make the FileSystem option public? That would allow anyone to provide their own FileSystem implementation that is a no-op?

@daveleek
Copy link
Contributor

We should probably not expose this interface/property directly. This is a strange and very technology tied abstraction that is due a redo, so we don't want to commit ourselves to it. We should start work on an abstraction that gets us closer to where we want to be headed with this SDK, that would allow us to specify backup handling noop/custom/file/etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: For later
Development

No branches or pull requests

4 participants