Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lighthouse Inconsistent Report - Best Practices #145

Closed
samuelcastro opened this issue Jul 29, 2020 · 3 comments · Fixed by #214
Closed

Lighthouse Inconsistent Report - Best Practices #145

samuelcastro opened this issue Jul 29, 2020 · 3 comments · Fixed by #214
Assignees
@Vadorequest
Labels
enhancement New feature or request
Projects
Enhancements and new features

Comments

@samuelcastro
Copy link
Contributor

This is just to document and track the issue described on this issue: GoogleChrome/lighthouse#10876
@Vadorequest Vadorequest added this to Awaiting (unsure, not planned) in Enhancements and new features Sep 3, 2020
@Vadorequest
Copy link
Member

I've found a way to solve this, working on our private NRN fork.

Basically, the bad performance is due to enabling preview mode in staging, I found a way not to do this when Cypress/LightHouse is running, which increases performances.

I'll implement it at some point, it's trivial.

@Vadorequest Vadorequest self-assigned this Nov 3, 2020
@Vadorequest Vadorequest added the enhancement New feature or request label Nov 3, 2020
@Vadorequest Vadorequest moved this from Awaiting (not ready, not planned) to To do in Enhancements and new features Nov 3, 2020
@samuelcastro
Copy link
Contributor Author

Awesome!

@Vadorequest Vadorequest moved this from To do to In progress in Enhancements and new features Nov 21, 2020
@Vadorequest Vadorequest linked a pull request Nov 21, 2020 that will close this issue
Improve LightHouse performances #214
Merged
@Vadorequest
Copy link
Member

Done in #214

Enhancements and new features automation moved this from In progress to Done Nov 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Vadorequest Vadorequest

Labels
enhancement New feature or request
Projects
Enhancements and new features
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve LightHouse performances UnlyEd/next-right-now
2 participants
@Vadorequest @samuelcastro