Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: Using release hook instead of success to save release information in context #15

Open
wovalle opened this issue Aug 20, 2019 · 1 comment

Comments

@wovalle
Copy link
Contributor

wovalle commented Aug 20, 2019

This semantic release plugin uses the success semantic release's hook to create and publish the release on JIRA.

This is ok if you don't need the release information in the context, my case was particular in which I do need to extract the release url from the context to emit some notifications. Moving the operations from success to publish allowed me to store the result of the publish in context.releases and it can be used down the road.

Now comes the discussion part: Do you think this is something you'd like to do with this plugin? I currently have the functionality in a fork but can make a PR if desired.

@wovalle
Copy link
Contributor Author

wovalle commented Oct 22, 2019

Hey @GabrielCastro, is this something desired?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant