Simplified Kernel creation and reuse
#4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Added `Shader` struct (wrapper over wgpu::ShaderModule). + Added `Program` struct (Shader + entry point + bindings). It represents a function in a `Shader`. * `Kernel` is created from a `Program`. It is the execution of it. * `DescriptorSet` derives `Clone`. * Updated all examples to new setup. - Removed `KernelBuilder`: it added complexity. - Removed `utils::shaders` module. Functionality is now on `Shader`. -----TODO----- % `webcam` example does not work. Device lost 馃毄 % Update and check documentation. Update README as well.
|
It seems the NVIDIA driver for WSL2 CUDA enablement is making |
UpsettingBoy
commented
Nov 17, 2021
src/kernel.rs
Outdated
| impl<'fw, 'res, 'sha> KernelBuilder<'fw, 'res, 'sha> { | ||
| /// Adds a [`DescriptorSet`] into the [`KernelBuilder`] internal layout. | ||
| impl Shader { | ||
| /// Creates a [`wgpu::ShaderModule`] instance from a SPIR-V file. |
src/kernel.rs
Outdated
| } | ||
| } | ||
|
|
||
| /// Adds a [`DescriptorSet`] for this [`Program`]. |
src/kernel.rs
Outdated
| } | ||
|
|
||
| impl<'fw> Kernel<'fw> { | ||
| /// Creates a [`KernelBuilder`] from a [`Program`]. |
There was a problem hiding this comment.
Change this entire bit of documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shaderstruct (wrapper over wgpu::ShaderModule).Programstruct (Shader + entry point + bindings). It representsa function in a
Shader.Kernelis created from aProgram. It is the execution of it.DescriptorSetderivesClone.KernelBuilder: it added complexity.utils::shadersmodule. Functionality is now onShader.-----TODO-----
%
webcamexample does not work. Device lost 馃毄% Update and check documentation. Update README as well.