Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sorting key for users #4

Merged
merged 10 commits into from Jan 11, 2021
Merged

Add sorting key for users #4

merged 10 commits into from Jan 11, 2021

Conversation

thejungwon
Copy link
Contributor

db2csv 함수에, sorting_key 파라미터를 추가하였고, 일단 default로 username을 넣어 두었습니다.

User를 sorting 하는 부분

## Sort by key
if sorting_key in columns:
    users = sorted(users, key=lambda k: k[sorting_key]) 

@hunkim
Copy link
Contributor

hunkim commented Jan 11, 2021

app.py에서 전달을 해야 할듯 한데 일단은 고고 할께요. 그리고 pytest도 경험많으시면 test케이스도 좀 필요할듯 합니다.

@thejungwon
Copy link
Contributor Author

app.py에서 전달을 해야 할듯 한데 일단은 고고 할께요. 그리고 pytest도 경험많으시면 test케이스도 좀 필요할듯 합니다.

네 그 부분도 한번 준비해보겠습니다.

@hunkim hunkim merged commit 046b73a into UpstageAI:main Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants