Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Add polishing compatibility with other mods #62

Closed
Numerosityy opened this issue Aug 27, 2023 · 13 comments
Closed

Suggestion: Add polishing compatibility with other mods #62

Numerosityy opened this issue Aug 27, 2023 · 13 comments

Comments

@Numerosityy
Copy link

You can right click with modded blocks and their polished version will be made
Mods that could have this functionality would include:
Quark
Unearthed
Unusual End
Abundant Atmosphere
Twigs
Regions Unexplored
Darker Depths
Architect's Palette
Enlightend
Stoneworks
Sculpt
NotEnoughBlocks

Alternative solution:
Possibly use a script to automatically recognize these types of blocks

@Uraneptus
Copy link
Owner

Hey, we really want to support as many mods as possible, but adding recipes to all these mods will take an incredible amount of time and effort from our team. We want to spend this time on other features tho.
However, you or anyone else can open a PR here on github and add the json recipe files for any other mod.
Just add the files to: src/main/resources/data/sullysmod/recipes/grindstone_polishing

@Numerosityy
Copy link
Author

I'd definitely be down to do it, thanks for the quick reply

@Uraneptus
Copy link
Owner

If you add the recipe files, make sure it looks like this:

{
  "type": "forge:conditional",
  "recipes": [
    {
      "conditions": [
        {
          "type": "forge:mod_loaded",
          "modid": "quark"
        }
      ],
      "recipe": {
        "type": "sullysmod:grindstone_polishing",
        "experience": 0,
        "ingredient": "quark:calcite",
        "result": "quark:polished_calcite",
        "resultCount": 1
      }
    }
  ]
}

Otherwise the game will crash when trying to load a world.
If you have any question feel free to DM me or reach out to us in our discord!

@Numerosityy
Copy link
Author

Is there a system like the Polymorph mod that checks for duplicate recipes with the grindstone right click recipes? Some of these blocks are identical and have the same recipe, but I don't want to cause a crash if both mods are installed

@Numerosityy
Copy link
Author

@Numerosityy
Copy link
Author

@Uraneptus Sorry I don't know how I should PR this, if you want to do it go right ahead

@Uraneptus
Copy link
Owner

Don't worry I can add the files! Thank you for the effort. ^^

@Uraneptus
Copy link
Owner

Is there a system like the Polymorph mod that checks for duplicate recipes with the grindstone right click recipes? Some of these blocks are identical and have the same recipe, but I don't want to cause a crash if both mods are installed

Could you tell me which blocks from which mods you are talking about?

@Numerosityy
Copy link
Author

Numerosityy commented Aug 31, 2023

Is there a system like the Polymorph mod that checks for duplicate recipes with the grindstone right click recipes? Some of these blocks are identical and have the same recipe, but I don't want to cause a crash if both mods are installed

Could you tell me which blocks from which mods you are talking about?

Well I was a little worried about the fact that there are duplicate blocks that use the same recipes (ex: quark and twigs both have polished calcite). But honestly things like this aren't that inconvenient so I just left out one of the recipes. I wouldn't be too worried about this

@Numerosityy
Copy link
Author

Do you think you are gonna release the mod with just this change for 1.19.2 now? Or are you gonna make more changes and then release?

@Uraneptus
Copy link
Owner

We have a few small changes we're currently working on and we'll release a last 1.19 update with your recipes and those changes.

@Uraneptus
Copy link
Owner

Well I was a little worried about the fact that there are duplicate blocks that use the same recipes (ex: quark and twigs both have polished calcite). But honestly things like this aren't that inconvenient so I just left out one of the recipes. I wouldn't be too worried about this

Ah I see what you mean. A system that would let you decide between a few available results for the same input item would be quite useful.
I will put this on my possible-ideas list.
If you have something in mind as to how a system like this could look like in game, let me know

@Numerosityy
Copy link
Author

We have a few small changes we're currently working on and we'll release a last 1.19 update with your recipes and those changes.

Sounds good, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants