Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hard-coded parameter values #231

Open
nickmalleson opened this issue Dec 17, 2020 · 3 comments
Open

Remove hard-coded parameter values #231

nickmalleson opened this issue Dec 17, 2020 · 3 comments
Assignees
@nickmalleson @spoonerf
Labels
enhancement New feature or request

Comments

@nickmalleson
Copy link
Collaborator

It's dangerous to have hard-coded values in the Params constructor

RAMP-UA/microsim/opencl/ramp/params.py

Line 28 in 4f55459

def __init__(self,

Remove these defaults. If they're needed (e.g. for defining slider ranges in the GUI) then call a separate (factory?) to return a Params object.
@nickmalleson nickmalleson added the enhancement New feature or request label Dec 17, 2020
@nickmalleson nickmalleson self-assigned this Dec 17, 2020
@github-actions
Copy link

Branch nickmalleson-issue-231 created!

@github-actions
Copy link

Branch spoonerf-issue-231 created!

@nickmalleson nickmalleson mentioned this issue Dec 17, 2020
Open
@nickmalleson
Copy link
Collaborator Author

(Maybe a duplicate of #229 ), probably close this in the new year and work on the other one

@ciupava ciupava mentioned this issue Mar 9, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nickmalleson nickmalleson

@spoonerf spoonerf

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nickmalleson @spoonerf