Skip to content
This repository has been archived by the owner on Jul 2, 2021. It is now read-only.

add remove a single subscriber #38

Merged
merged 2 commits into from Jul 23, 2019
Merged

add remove a single subscriber #38

merged 2 commits into from Jul 23, 2019

Conversation

vincentvvv
Copy link
Contributor

@vincentvvv vincentvvv commented Jul 19, 2019

There was no method to remove a single subscriber.

Subscribe will return a subscriber which can then be used to call removeSubscriber by the Observable.

https://compass-tech.atlassian.net/browse/MOBILE-4799

@codecov
Copy link

codecov bot commented Jul 19, 2019

Codecov Report

Merging #38 into master will increase coverage by 0.53%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
+ Coverage   90.59%   91.12%   +0.53%     
==========================================
  Files          10       10              
  Lines         117      124       +7     
  Branches       12       13       +1     
==========================================
+ Hits          106      113       +7     
  Misses          7        7              
  Partials        4        4
Impacted Files Coverage Δ
...l-kotlin/src/main/java/com/compass/snail/Replay.kt 100% <100%> (ø) ⬆️
...ail-kotlin/src/main/java/com/compass/snail/Just.kt 100% <100%> (ø) ⬆️
...tlin/src/main/java/com/compass/snail/Observable.kt 88.5% <100%> (+0.41%) ⬆️
...ail-kotlin/src/main/java/com/compass/snail/Fail.kt 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41edda1...c61512e. Read the comment docs.

@russellbstephens
Copy link
Contributor

blocking - lets also look at a possible autodispose solution

@russellbstephens russellbstephens merged commit b5897e2 into master Jul 23, 2019
@delete-merged-branch delete-merged-branch bot deleted the removeSubscriber branch July 23, 2019 22:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants