-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to return with non-zero exit code if diff finds breaking/dangerous changes #304
Comments
Yep! The major upside here is including a breaking change check in a CI. I'll be using a script to do the same but would be nice to be built into the |
@redreceipt I ended up creating a dedicated tool for this. You can check it out here: https://github.com/fabsrc/graphql-schema-diff |
@fabsrc excellent! Thank you! |
We've just released new alpha versions channel for GraphQL CLI - We use GraphQL Inspector as the default package for the @fabsrc your tool looks great! would you like to collaborate with us on GraphQL Inspector? Checkout new instructions and the migration guide and we will be happy to hear your feedback during that alpha period! Feel free to contact us by opening an issue or using our Discord channel; |
I've posted the wrong Discord link, this is the correct one: https://discord.gg/xud7bH9 |
Right now the
diff
command only prints out the schema diff and points out breaking/dangerous changes. It would be cool if there was an option like--fail-on-breaking-changes
/--fail-on-dangerous-changes
to make the tool return with a non-zero exit code. This would be particularly useful in a CI job that compares the schema with the prod environment and should fail if there are any breaking changes.I'm currently using a bash script to achieve this:
However I think it makes sense to implement this feature into the tool.
The text was updated successfully, but these errors were encountered: