fix(cli): WebSocket clients mustn't provide connectionParams
#4270
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mesh server will fail with
TypeError: Cannot read properties of undefined (reading 'headers')
if WebSocket clients don't provide anyconnectionParams
at this location:https://github.com/Urigo/graphql-mesh/blob/a134d17deba62db438d68f1ee81ef4adbcf32691/packages/cli/src/commands/serve/serve.ts#L173
Type of change
How Has This Been Tested?
Start any Mesh server, connect to it using GraphiQL with WebSockets only.
Checklist:
I have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationMy changes generate no new warningsI have added tests that prove my fix is effective or that my feature worksFurther comments
The weirdest thing is: why are the
connectionParams
not considered optional (because they really are and here too)?