Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ObservableCollection.d.ts: error TS2314: Generic type 'Selector' / 'Modifier' requires 1 type argument(s). #230

Open
KeithGillette opened this issue Aug 13, 2018 · 5 comments
Open

ObservableCollection.d.ts: error TS2314: Generic type 'Selector' / 'Modifier' requires 1 type argument(s). #230

KeithGillette opened this issue Aug 13, 2018 · 5 comments

Comments

@KeithGillette
Copy link

Updating an Angular 6.1.2 project with rxjs@6.2.2 to meteor-rxjs@0.4.14 produces the following errors in combination with @types/meteor@1.4.16 when transpiling under typescript@2.9.2

node_modules/meteor-rxjs/dist/ObservableCollection.d.ts(96,26): error TS2314: Generic type 'Selector' requires 1 type argument(s).
node_modules/meteor-rxjs/dist/ObservableCollection.d.ts(108,26): error TS2314: Generic type 'Selector' requires 1 type argument(s).
node_modules/meteor-rxjs/dist/ObservableCollection.d.ts(108,78): error TS2314: Generic type 'Modifier' requires 1 type argument(s).
node_modules/meteor-rxjs/dist/ObservableCollection.d.ts(124,26): error TS2314: Generic type 'Selector' requires 1 type argument(s).
node_modules/meteor-rxjs/dist/ObservableCollection.d.ts(124,78): error TS2314: Generic type 'Modifier' requires 1 type argument(s).
node_modules/meteor-rxjs/dist/ObservableCollection.d.ts(146,25): error TS2314: Generic type 'Selector' requires 1 type argument(s).
node_modules/meteor-rxjs/dist/ObservableCollection.d.ts(163,28): error TS2314: Generic type 'Selector' requires 1 type argument(s).

Reverting to @types/meteor@0.4.14 corrects the issue.

Whose typings are correct?
@KeithGillette KeithGillette changed the title ObservableCollection.d.ts: error TS2314: Generic type 'Selector' \ 'Modifier' requires 1 type argument(s). ObservableCollection.d.ts: error TS2314: Generic type 'Selector' / 'Modifier' requires 1 type argument(s). Aug 13, 2018
@KeithGillette
Copy link
Author

Update: I still receive these same errors when running tsc with latest releases:

  • typescript@3.1.6
  • angular@7.1.0
  • rxjs@6.3.3
  • meteor-rxjs@0.4.14
  • @types/meteor@1.4.23

Reverting to @types/meteor@1.4.14 corrects the issue.

@georgyberdyshev georgyberdyshev mentioned this issue Nov 30, 2018
Merged
@KeithGillette
Copy link
Author

Update: I still receive these same errors when running tsc with latest releases:

  • typescript@3.2.4
  • angular@7.2.2
  • rxjs@6.3.3
  • meteor-rxjs@0.4.14
  • @types/meteor@1.4.24

Reverting to @types/meteor@1.4.14 corrects the issue.

@YamanSehzade
Copy link

Hi @KeithGillette ,
I am using "@types/meteor": "^1.4.14",

On my localy everyting is OK. But when NETLIFY build this project i get same error....

Have you any opinion ? Thanks...

This is deploy log;


11:41:02 PM: Build ready to start
11:41:05 PM: build-image version: 84aca9ba39e0ee86ba194760fbfc51a808f62543
11:41:05 PM: buildbot version: 57d44fd1631cc3fff8b38fbaf88d3d04f946418a
11:41:05 PM: Fetching cached dependencies
11:41:05 PM: Failed to fetch cache, continuing with build
11:41:05 PM: Starting to prepare the repo for build
11:41:06 PM: No cached dependencies found. Cloning fresh repo
11:41:06 PM: git clone https://github.com/YamanSehzade/****-****-****
11:41:07 PM: Preparing Git Reference refs/heads/master
11:41:08 PM: Starting build script
11:41:08 PM: Installing dependencies
11:41:10 PM: Downloading and installing node v8.15.0...
11:41:10 PM: Downloading https://nodejs.org/dist/v8.15.0/node-v8.15.0-linux-x64.tar.xz...
11:41:10 PM:   0.9%
11:41:10 PM: 
#############
11:41:10 PM:  18.1%
11:41:10 PM: 
###############################                                           43.8%
11:41:10 PM: 
##################################################
11:41:10 PM:  69.9%
11:41:10 PM: 
#################################################################         90.9%
11:41:10 PM: 
######################################################################## 100.0%
11:41:11 PM: Computing checksum with sha256sum
11:41:11 PM: Checksums matched!
11:41:13 PM: Now using node v8.15.0 (npm v6.4.1)
11:41:14 PM: Attempting ruby version 2.3.6, read from environment
11:41:15 PM: Using ruby version 2.3.6
11:41:15 PM: Using PHP version 5.6
11:41:15 PM: Started restoring cached node modules
11:41:15 PM: Finished restoring cached node modules
11:41:16 PM: Installing NPM modules using NPM version 6.4.1
11:41:24 PM: npm
11:41:24 PM: WARN deprecated circular-json@0.5.9: CircularJSON is in maintenance only, flatted is its successor.
11:41:29 PM: npm WARN
11:41:29 PM: deprecated socks@1.1.10: If using 2.x branch, please upgrade to at least 2.1.6 to avoid a serious bug with socket data flow and an import issue introduced in 2.1.0
11:42:15 PM: > node-sass@4.10.0 install /opt/build/repo/node_modules/node-sass
11:42:15 PM: > node scripts/install.js
11:42:15 PM: Downloading binary from https://github.com/sass/node-sass/releases/download/v4.10.0/linux-x64-57_binding.node
11:42:16 PM: Download complete
11:42:16 PM: Binary saved to /opt/build/repo/node_modules/node-sass/vendor/linux-x64-57/binding.node
11:42:16 PM: Caching binary to /opt/buildhome/.npm/node-sass/4.10.0/linux-x64-57_binding.node
11:42:17 PM: > node-sass@4.10.0 postinstall /opt/build/repo/node_modules/node-sass
11:42:17 PM: > node scripts/build.js
11:42:17 PM: Binary found at /opt/build/repo/node_modules/node-sass/vendor/linux-x64-57/binding.node
11:42:17 PM: Testing binary
11:42:18 PM: Binary is fine
11:42:21 PM: npm notice
11:42:21 PM:  created a lockfile as package-lock.json. You should commit this file.
11:42:21 PM: npm WARN @angular/animations@7.2.2 requires a peer of @angular/core@7.2.2 but none is installed. You must install peer dependencies yourself.
11:42:21 PM: npm WARN @ionic-native/barcode-scanner@5.0.0 requires a peer of @ionic-native/core@5.0.0 but none is installed. You must install peer dependencies yourself.
11:42:21 PM: npm WARN @ionic-native/camera@5.0.0 requires a peer of @ionic-native/core@5.0.0 but none is installed. You must install peer dependencies yourself.
11:42:21 PM: npm WARN @ionic-native/clipboard@5.0.0 requires a peer of @ionic-native/core@5.0.0 but none is installed. You must install peer dependencies yourself.
11:42:21 PM: npm WARN @ionic-native/device@5.0.0 requires a peer of @ionic-native/core@5.0.0 but none is installed. You must install peer dependencies yourself.
11:42:21 PM: npm WARN @ionic-native/code-push@5.0.0 requires a peer of @ionic-native/core@5.0.0 but none is installed. You must install peer dependencies yourself.
11:42:21 PM: npm WARN @ionic-native/in-app-browser@5.0.0 requires a peer of @ionic-native/core@5.0.0 but none is installed. You must install peer dependencies yourself.
11:42:21 PM: npm WARN @ionic-native/firebase@5.0.0 requires a peer of @ionic-native/core@5.0.0 but none is installed. You must install peer dependencies yourself.
11:42:21 PM: npm WARN @ionic-native/screen-orientation@5.0.0 requires a peer of @ionic-native/core@5.0.0 but none is installed. You must install peer dependencies yourself.
11:42:21 PM: npm WARN angular2-moment@1.9.0 requires a peer of @angular/core@>=2.0.0 <6.0.0 but none is installed. You must install peer dependencies yourself.
11:42:22 PM: npm WARN @swimlane/ngx-charts@10.0.0 requires a peer of @angular/cdk@7.x but none is installed. You must install peer dependencies yourself.
11:42:22 PM: npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@1.2.7 (node_modules/fsevents):
11:42:22 PM: npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@1.2.7: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
11:42:22 PM: added 1461 packages from 1318 contributors and audited 51744 packages in 64.618s
11:42:22 PM: found 2 vulnerabilities (1 low, 1 high)
11:42:22 PM:   run `npm audit fix` to fix them, or `npm audit` for details
11:42:22 PM: NPM modules installed
11:42:22 PM: Started restoring cached go cache
11:42:22 PM: Finished restoring cached go cache
11:42:22 PM: unset GOOS;
11:42:23 PM: unset GOARCH;
11:42:23 PM: export GOROOT='/opt/buildhome/.gimme/versions/go1.10.linux.amd64';
11:42:23 PM: export PATH="/opt/buildhome/.gimme/versions/go1.10.linux.amd64/bin:${PATH}";
11:42:23 PM: go version >&2;
11:42:23 PM: export GIMME_ENV='/opt/buildhome/.gimme/env/go1.10.linux.amd64.env';
11:42:23 PM: go version go1.10 linux/amd64
11:42:23 PM: Installing missing commands
11:42:23 PM: Verify run directory
11:42:23 PM: Executing user command: ionic build --prod
11:42:23 PM: > ng run app:build:production
11:42:46 PM: Date: 2019-01-29T22:42:46.502Z
11:42:46 PM: Hash: adaa4b7c034e14f51b80
11:42:46 PM: Time: 19703ms
11:42:46 PM: chunk {0} runtime.ec2944dd8b20ec099bf3.js (runtime) 1.41 kB [entry] [rendered]
11:42:46 PM: chunk {1} main.9868d9b237c3a48c54da.js (main) 128 bytes [initial] [rendered]
11:42:46 PM: chunk {2} polyfills.85f47f0bf59079cbc23a.js (polyfills) 130 bytes [initial] [rendered]
11:42:46 PM: chunk {3} styles.4f7679d8f01aed9e0a80.css (styles) 18.3 kB [initial] [rendered]
11:42:46 PM: ERROR in node_modules/meteor-rxjs/dist/ObservableCollection.d.ts(96,26): error TS2314: Generic type 'Selector' requires 1 type argument(s).
11:42:46 PM: node_modules/meteor-rxjs/dist/ObservableCollection.d.ts(108,26): error TS2314: Generic type 'Selector' requires 1 type argument(s).
11:42:46 PM: node_modules/meteor-rxjs/dist/ObservableCollection.d.ts(108,78): error TS2314: Generic type 'Modifier' requires 1 type argument(s).
11:42:46 PM: node_modules/meteor-rxjs/dist/ObservableCollection.d.ts(124,26): error TS2314: Generic type 'Selector' requires 1 type argument(s).
11:42:46 PM: node_modules/meteor-rxjs/dist/ObservableCollection.d.ts(124,78): error TS2314: Generic type 'Modifier' requires 1 type argument(s).
11:42:46 PM: node_modules/meteor-rxjs/dist/ObservableCollection.d.ts(146,25): error TS2314: Generic type 'Selector' requires 1 type argument(s).
11:42:46 PM: node_modules/meteor-rxjs/dist/ObservableCollection.d.ts(163,28): error TS2314: Generic type 'Selector' requires 1 type argument(s).
11:42:46 PM: [ERROR] An error occurred while running subprocess ng.
11:42:46 PM:         ng run app:build:production exited with exit code 1.
11:42:46 PM:         Re-running this command with the --verbose flag may provide more information.
11:42:46 PM: Caching artifacts
11:42:46 PM: Started saving node modules
11:42:46 PM: Finished saving node modules
11:42:46 PM: Started saving pip cache
11:42:46 PM: Finished saving pip cache
11:42:46 PM: Started saving emacs cask dependencies
11:42:46 PM: Finished saving emacs cask dependencies
11:42:46 PM: Started saving maven dependencies
11:42:47 PM: Finished saving maven dependencies
11:42:47 PM: Started saving boot dependencies
11:42:47 PM: Finished saving boot dependencies
11:42:47 PM: Started saving go dependencies
11:42:47 PM: Finished saving go dependencies
11:42:47 PM: Cached node version v8.15.0
11:42:47 PM: Error running command: Build script returned non-zero exit code: 1
11:42:47 PM: Failing build: Failed to build site
11:42:47 PM: failed during stage 'building site': Build script returned non-zero exit code: 1
11:42:47 PM: Finished processing build request in 1m42.651246638s

@KeithGillette
Copy link
Author

KeithGillette commented Jan 30, 2019 •
edited

@YamanSehzade: It doesn't look like you have pinned the version at 1.4.14, as the caret in front of the version number will allow installations of newer semver "compatible" versions. Check the actual installed version with npm list @types/meteor. I recommend removing the caret and reinstalling:
npm install --save-exact --save @types/meteor@1.4.14.

@YamanSehzade
Copy link

thanks @KeithGillette, it worked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@KeithGillette @YamanSehzade