Skip to content
This repository has been archived by the owner on Jan 23, 2024. It is now read-only.

More maintainers #1

Open
Uriopass opened this issue Dec 24, 2023 · 15 comments
Open

More maintainers #1

Uriopass opened this issue Dec 24, 2023 · 15 comments

Comments

@Uriopass
Copy link
Owner

I am open to add more maintainers to this project (github & crates.io rights) that want to have the latest bindings so that it doesn't depend on a single person.

Ping @BeastLe9enD, @oisyn and @gents83 as you recently contributed new bindings/changes to meshopt

@BeastLe9enD
Copy link
Collaborator

Considering the fact that the crate on Github was last updated over a year ago (and November 2019 on crates.io), I think the is the best way to go. I would like to help as a maintainer!

@oisyn
Copy link
Collaborator

oisyn commented Dec 24, 2023

Same here!

@oisyn
Copy link
Collaborator

oisyn commented Dec 24, 2023

Have you tried reaching out to @gwihlidal to see if he was maybe interested in handing over the crates.io rights at least?

@BeastLe9enD
Copy link
Collaborator

good point, maybe we could try asking him on twitter (I think Github issues is not the best way to reach him)

@Uriopass
Copy link
Owner Author

You're right, I didn't think of that!

@Uriopass
Copy link
Owner Author

Uriopass commented Dec 24, 2023

I'll send him a message on twitter

EDIT: Done

@Uriopass
Copy link
Owner Author

Uriopass commented Dec 24, 2023

In the meantime, I have added you both to meshopt2 on crates.io too 👍

@BeastLe9enD
Copy link
Collaborator

BeastLe9enD commented Dec 29, 2023

@Uriopass Have you received an answer so far?

@Uriopass
Copy link
Owner Author

No answers :/

@gwihlidal
Copy link

Hey all,

Sorry I've been busy, but I'm definitely up for getting help maintaining this crate! I can add you all to this repo and also crates.io

I've been hoping to find some time again to resume crate dev, but getting your help will be awesome.

Thank you,
Graham

@Uriopass
Copy link
Owner Author

I can add you all to this repo and also crates.io

That would be great! Thank you

@JMS55
Copy link

JMS55 commented Jan 22, 2024

Hi. I'm using meshopt in Bevy for meshlet generation. Currently, I'm using my own fork of meshopt that exposes some non-public fields and implements DecodePosition for an array of floats. In the future, I'm also going to need Traverse Research's fork that exposes simplifying meshes while locking edges (included in my branch atm, although I don't currently use it).

A prerequisite to being able to merge my code into Bevy is depending on a crates.io published crate, instead of a git fork. Would you be interested in merging my (small commits), and possibly Traverse Research's additional API, and then publishing a new crates.io release of meshopt2?

@Uriopass
Copy link
Owner Author

Uriopass commented Jan 22, 2024

Absolutely open to that, these seem like good API changes!

It might be better to wait for @gwihlidal to give us maintaining control over the original crate though, as it'd be a bit less confusing

@oisyn
Copy link
Collaborator

oisyn commented Jan 22, 2024

Keep in mind that our fork (I work at Traverse 😉) is dependent on zeux/meshoptimizer#601 to be merged. We could of course opt to use the Traverse fork of the C++ library as basis in the mean time -- I would personally favor that as that would remove some patches in our Cargo.toml, but I'm a bit biased here 😄.

@gwihlidal
Copy link

I have added @Uriopass, @BeastLe9enD, @oisyn and @gents83 as maintainers to the meshopt repository, as well as crates.io - thank you very much for the help!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants