Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose an endpoint for retrieving image data #1

Closed
Utagai opened this issue Nov 27, 2020 · 1 comment
Closed

Expose an endpoint for retrieving image data #1

Utagai opened this issue Nov 27, 2020 · 1 comment

Comments

@Utagai
Copy link
Owner

Utagai commented Nov 27, 2020

This will benefit from the natural parallelism of how browsers make requests for URLs in the HTML of a page. Currently, we serially insert the base64 encoding of every image into the HTML file, so the page load takes a while for a large selection of images.

This gives disk access to API callers, so we must be careful to limit the surface area of the filesystem that can be touched with this endpoint.

@Utagai
Copy link
Owner Author

Utagai commented Nov 27, 2020

It's worth noting that we also pay for the memory that is required to hold the bytes of every image in memory. This can be quite large if we watch a significant number of images, or very large ones.

@Utagai Utagai closed this as completed Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant