Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback needed for new changes in new-org branch #45

Closed
UtkarshVerma opened this issue Mar 26, 2023 · 2 comments
Closed

Feedback needed for new changes in new-org branch #45

UtkarshVerma opened this issue Mar 26, 2023 · 2 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@UtkarshVerma
Copy link
Owner

I think I have found a fix #24 . It was pretty simple looking back at it. Anyhow, the fix is in the new-org branch. I was playing around with the build system and code organization, so haven't merged it to main yet.

I'm facing the following problem currently, and feedback and help would be highly appreciated:

  • I have to define blocks in blocks.c for the time being, which isn't good because everything should ideally be in config.h.
  • I need to find a way for the compiler to dynamically figure out the number of blocks. Currently N_BLOCKS macro has to be defined manually, which isn't good.
@UtkarshVerma UtkarshVerma added the help wanted Extra attention is needed label Mar 26, 2023
@UtkarshVerma UtkarshVerma self-assigned this Mar 26, 2023
@UtkarshVerma UtkarshVerma pinned this issue Mar 26, 2023
@UtkarshVerma UtkarshVerma unpinned this issue Mar 28, 2023
@UtkarshVerma
Copy link
Owner Author

Changes have been merged to main.

@hillyu
Copy link

hillyu commented Nov 3, 2023

Hey, I think the block script still can be blocked from running, maybe we can just kill the process instead when executing the block, something like:
int block_execute(block const block, const uint8_t button) {
// Ensure only one child process exists per block at an instance.
if (block->fork_pid != -1) {
/
return 0; */
kill(block->fork_pid, 9);
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants