Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring Tabbed Slide Show on V² Home Page (aka Big Picture) #216

Open
2 of 8 tasks
VillageHubertChen opened this issue Jul 20, 2016 · 0 comments
Open
2 of 8 tasks

Comments

@VillageHubertChen
Copy link
Member

VillageHubertChen commented Jul 20, 2016

Tasks

  • Research that all parts of angular you want to use do not turn on routing
  • Publish a list below of all parts that turn on angular routing for future reference
  • Write documentation on the new tabbed slide show
  • Trigger HC to review documentation
  • Code the new tabbed slide show
  • Trigger HC to test on local machine
  • Push to V²Site, trigger HC for immediate testing
  • Fix bugs if needed. Repeat until all is well.

Why refactoring became necessary

The current version was based on $location. This angular object automatically turned on Angular Routing. In turn this broke anchors on a page based on hashtag. This is discussed in detail in → Ben Nadel > Using Anchor Tags And URL-Fragment Links In AngularJS.

To fix → Bug: Stop Angular from Rerouting Hashtag #154 we had to turn off angular routing. As such we needed to remove $location. In turn we broke the Tabbed Slide Show on the Home Page. And that is why we need to refactor it.

Replacing $location with Angular Scroll Service

??? Lukas, do explain!

Order of initialization (least to most important)

  1. On startup open the first tab
  2. Specify attribute with two way data binding
  3. Look at the URL and select the tab according to hashtag

References

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants