Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

62 introduce the index selector non negative into the recursive engine #132

Merged
merged 24 commits into from
May 22, 2023
Merged

62 introduce the index selector non negative into the recursive engine #132

merged 24 commits into from
May 22, 2023

Conversation

zwerdlds
Copy link
Collaborator

@zwerdlds zwerdlds commented May 9, 2023 •
edited
Loading

README

This PR implements the non-negative array index selector.

Issue

Resolves: #64

Checklist

  • I ran just verify locally and it succeeded.
  • Issue was given go ahead and is linked above
  • Unit tests for my changes are included

@zwerdlds zwerdlds self-assigned this May 9, 2023
@zwerdlds zwerdlds changed the base branch from 62-introduce-the-index-selector-non-negative-into-the-recursive-engine to main May 9, 2023 20:54
@zwerdlds zwerdlds force-pushed the 62-introduce-the-index-selector-non-negative-into-the-recursive-engine branch from f423485 to b4b8e3a Compare May 14, 2023 23:41
V0ldek
V0ldek requested changes May 18, 2023
View reviewed changes
Copy link
Member

@V0ldek V0ldek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't review the engines and the minimizer tests, will do that as a second batch.

crates/rsonpath-lib/src/engine.rs Outdated Show resolved Hide resolved
crates/rsonpath-lib/src/engine.rs Outdated Show resolved Hide resolved
crates/rsonpath-lib/src/query.rs Outdated Show resolved Hide resolved
crates/rsonpath-lib/src/query/automaton.rs Outdated Show resolved Hide resolved
crates/rsonpath-lib/src/query/automaton.rs Outdated Show resolved Hide resolved
crates/rsonpath-lib/src/query/error.rs Outdated Show resolved Hide resolved
crates/rsonpath-lib/src/query/automaton.rs Outdated Show resolved Hide resolved
crates/rsonpath-lib/src/query/automaton.rs Outdated Show resolved Hide resolved
crates/rsonpath-lib/src/query/automaton.rs Outdated Show resolved Hide resolved
crates/rsonpath-lib/src/query/automaton/minimizer.rs Outdated Show resolved Hide resolved
@zwerdlds zwerdlds force-pushed the 62-introduce-the-index-selector-non-negative-into-the-recursive-engine branch from 30d6705 to 12d3f00 Compare May 18, 2023 20:48
@V0ldek V0ldek force-pushed the 62-introduce-the-index-selector-non-negative-into-the-recursive-engine branch from 242b4c4 to 872d60f Compare May 22, 2023 10:11
@zwerdlds zwerdlds marked this pull request as ready for review May 22, 2023 14:50
zwerdlds and others added 20 commits May 22, 2023 08:51
@zwerdlds
cherry picked from commit ef2f977 to merge non-negative array index
2027e9d 
Signed-off-by: David Zwerdling <zwerdlds@gmail.com>
@zwerdlds
verification fixups
41bc7b7 
Signed-off-by: David Zwerdling <zwerdlds@gmail.com>
@zwerdlds
nneg array indices tests
0fb8dd7 
Signed-off-by: David Zwerdling <zwerdlds@gmail.com>
@zwerdlds
initial main engine nneg array impl
66cd300 
Signed-off-by: David Zwerdling <zwerdlds@gmail.com>
@zwerdlds
more unit tests, sync with mat
0dcb9d7 
Signed-off-by: David Zwerdling <zwerdlds@gmail.com>
@zwerdlds
nneg array index increment check; reset array on new square bracket; …
1ae7a9f 
…better tests;

Signed-off-by: David Zwerdling <zwerdlds@gmail.com>
@zwerdlds
anydesc nneg array positive test; minor main cleanup
6454662 
Signed-off-by: David Zwerdling <zwerdlds@gmail.com>
@zwerdlds
nneg array index code complete
a1fede6 
Signed-off-by: David Zwerdling <zwerdlds@gmail.com>
@zwerdlds
test more accurate for stack pushing
d6acab8 
Signed-off-by: David Zwerdling <zwerdlds@gmail.com>
@zwerdlds
NonNegativeArrayIndex::ZERO const moved to type
33c48eb 
Signed-off-by: David Zwerdling <zwerdlds@gmail.com>
@zwerdlds
NonNegativeArray::MAX provided public instead of primitive
ff35356 
Signed-off-by: David Zwerdling <zwerdlds@gmail.com>
@zwerdlds
refactored nneg array index max and zero to const wrapped value in No…
ef0061d 
…nNegativeArrayIndex

Signed-off-by: David Zwerdling <zwerdlds@gmail.com>
@zwerdlds
TransitionLabel get_label and get_array_index fixed
776336d 
Signed-off-by: David Zwerdling <zwerdlds@gmail.com>
@zwerdlds
minimzer imports cleaned up
32bdac5 
Signed-off-by: David Zwerdling <zwerdlds@gmail.com>
@zwerdlds
minimzer imports cleaned up
b7df9f4 
Signed-off-by: David Zwerdling <zwerdlds@gmail.com>
@zwerdlds
merge cleanup
3600675 
Signed-off-by: David Zwerdling <zwerdlds@gmail.com>
@zwerdlds
invalid borrow removed
99f5bfe 
Signed-off-by: David Zwerdling <zwerdlds@gmail.com>
@zwerdlds @V0ldek
Improve documentation on TransitionLabel
f850253 
Co-authored-by: V0ldek <mat@gienieczko.com>
Signed-off-by: David Zwerdling <zwerdlds@gmail.com>
@zwerdlds
remove erroneous borrow (for now)
2890daf 
Signed-off-by: David Zwerdling <zwerdlds@gmail.com>
@zwerdlds
Borrow via from for TransitionLabel
0e23aac 
Signed-off-by: David Zwerdling <zwerdlds@gmail.com>
@zwerdlds
uses/mods reordered
93a1496 
Signed-off-by: David Zwerdling <zwerdlds@gmail.com>
@zwerdlds
list index overflow short circuit order corrected
9f01207 
Signed-off-by: David Zwerdling <zwerdlds@gmail.com>
@zwerdlds
precomputed non-negative array index selector stack vars
ecb084c 
Signed-off-by: David Zwerdling <zwerdlds@gmail.com>
@zwerdlds
cleanup for linter and erroneous unused code
01e4f71 
Signed-off-by: David Zwerdling <zwerdlds@gmail.com>
@zwerdlds zwerdlds force-pushed the 62-introduce-the-index-selector-non-negative-into-the-recursive-engine branch from 872d60f to 01e4f71 Compare May 22, 2023 15:54
@V0ldek V0ldek merged commit 2b250d6 into rsonquery:main May 22, 2023
21 checks passed
This was referenced May 22, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@V0ldek V0ldek V0ldek approved these changes

Assignees

@zwerdlds zwerdlds

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce the index selector (non-negative)
2 participants
@zwerdlds @V0ldek