Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve index selector performance by caching state attributes #138

Closed
V0ldek opened this issue May 22, 2023 · 1 comment · Fixed by #493
Closed

Improve index selector performance by caching state attributes #138

V0ldek opened this issue May 22, 2023 · 1 comment · Fixed by #493
Labels
area: performance Performance improvements type: feature New feature or request

Comments

@V0ldek
Copy link
Member

V0ldek commented May 22, 2023

Is your feature request related to a problem? Please describe.
The has_any_array_item_transition and has_any_array_item_transition_to_accepting functions in the Automaton are called from the engine, but they look through all the transitions.

Describe the solution you'd like
We have the facility to save such properties, the StateAttributes struct. It should be checked if caching these two properties as an attribute improves engine performance.

Describe alternatives you've considered
If the perf results are not improved then we can leave the dynamic check.
@V0ldek V0ldek added type: feature New feature or request area: performance Performance improvements mod: compiler labels May 22, 2023
@github-actions github-actions bot added the acceptance: triage Waiting for owner's input label May 22, 2023
@github-actions
Copy link

Tagging @V0ldek for notifications

@V0ldek V0ldek added acceptance: go ahead Reviewed, implementation can start and removed acceptance: triage Waiting for owner's input labels May 22, 2023
@V0ldek V0ldek mentioned this issue Mar 15, 2024
Merged
3 tasks
V0ldek added a commit that referenced this issue Mar 15, 2024
@V0ldek
perf: improve performance of the index selector
8910617 
added more structure and metadata to the automaton,
improving perf of all queries in general (~6% thpt) and
array-index queries in particular (~12% thpt)

ref: #138
@github-actions github-actions bot removed the acceptance: go ahead Reviewed, implementation can start label Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: performance Performance improvements type: feature New feature or request
Projects
Active rq development
Status: Released
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve performance of the index selector rsonquery/rsonpath
1 participant
@V0ldek