Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter selector – const atom comparisons [?<path> <binop> <atom>] #156

Open
V0ldek opened this issue Jun 14, 2023 · 1 comment
Open

Filter selector – const atom comparisons [?<path> <binop> <atom>] #156

V0ldek opened this issue Jun 14, 2023 · 1 comment
Labels
acceptance: go ahead Reviewed, implementation can start area: selector Support for a JSONPath selector type: feature New feature or request
Milestone

Comments

@V0ldek
Copy link
Member

V0ldek commented Jun 14, 2023

Is your feature request related to a problem? Please describe.
After #154, we can extend filters to test against a constant atomic value.

Describe the solution you'd like
This is easy, as the spec requires codepoint, bitwise comparison of strings, so no unicode handling comes into play. We do need parsing of integer values inside the JSON, since floating point comparison is not easy to do without actually parsing the number.

Additionally, there are "dumb" filters that should be handled this as well, like [?42 == 42] or [?42 != 42], so either always satisfied or never satisfied. These can just be collapsed to either not emitting a filter at all, or emitting an empty query matching nothing.

Additional context
RFC draft.

@V0ldek V0ldek added the type: feature New feature or request label Jun 14, 2023
@github-actions github-actions bot added the acceptance: triage Waiting for owner's input label Jun 14, 2023
@github-actions
Copy link

Tagging @V0ldek for notifications

@V0ldek V0ldek changed the title Filters – const atom comparisons [?<path> <binop> <atom>] Filter selector – const atom comparisons [?<path> <binop> <atom>] Jun 14, 2023
@V0ldek V0ldek added this to the v1.0.0 milestone Jun 15, 2023
@github-actions github-actions bot added acceptance: go ahead Reviewed, implementation can start and removed acceptance: triage Waiting for owner's input labels Jun 15, 2023
@V0ldek V0ldek added mod: engine area: selector Support for a JSONPath selector labels Jun 15, 2023
@V0ldek V0ldek mentioned this issue Feb 28, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acceptance: go ahead Reviewed, implementation can start area: selector Support for a JSONPath selector type: feature New feature or request
Projects
Development

No branches or pull requests

1 participant