Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove SHA from --version on crates.io #157

Merged
merged 1 commit into from
Jun 15, 2023
Merged

fix: remove SHA from --version on crates.io #157

merged 1 commit into from
Jun 15, 2023

Conversation

V0ldek
Copy link
Member

@V0ldek V0ldek commented Jun 15, 2023

Issue

Minor. The Commit SHA part was incorrect, and there seems to be no way to get it when the crate is in registry.

Checklist

All of these should be ticked off before you submit the PR.

  • I ran just verify locally and it succeeded.
  • Issue was given go ahead and is linked above OR I have included justification for a minor change.
  • Unit tests for my changes are included OR no functionality was changed.

@V0ldek
fix: remove SHA from --version on crates.io
b6acbbb 
The Commit SHA part was incorrect, and there seems to be no way to get it when the crate is in registry
@V0ldek V0ldek merged commit a390ca4 into main Jun 15, 2023
22 checks passed
@V0ldek V0ldek deleted the v0ldek/version-sha branch June 15, 2023 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@V0ldek