Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make query execution panic-free #39

Closed
V0ldek opened this issue Nov 13, 2022 · 0 comments · Fixed by #66
Closed

Make query execution panic-free #39

V0ldek opened this issue Nov 13, 2022 · 0 comments · Fixed by #66
Assignees
@V0ldek
Labels
area: library Improvements to the library API quality type: feature New feature or request type: reliability Tests, code quality
Milestone
v1.0.0

Comments

@V0ldek
Copy link
Member

V0ldek commented Nov 13, 2022

Is your feature request related to a problem? Please describe.
There are a couple of places in the classifiers and engines using unwrap. Remove them and create strongly-typed errors for those cases.

Describe the solution you'd like
Remove all panics and enable clippy::unwrap_used and clippy::expect_used lints.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.
@V0ldek V0ldek added type: feature New feature or request acceptance: go ahead Reviewed, implementation can start type: reliability Tests, code quality labels Nov 13, 2022
@V0ldek V0ldek self-assigned this Nov 13, 2022
@V0ldek V0ldek added this to the v1.0.0 milestone Nov 13, 2022
@V0ldek V0ldek mentioned this issue Nov 13, 2022
Closed
@V0ldek V0ldek mentioned this issue Nov 13, 2022
Closed
3 tasks
@V0ldek V0ldek added area: engine area: library Improvements to the library API quality and removed type: error handling labels Nov 23, 2022
@V0ldek V0ldek mentioned this issue Dec 14, 2022
Merged
V0ldek added a commit that referenced this issue Dec 14, 2022
@V0ldek
lib: panic-free classifiers and engines
7a19d1a 
Detectable errors now use proper error types instead of panics.
Added lints to prevent adding more panics or undocumented errors.

Related: #39, #40, #31
@github-actions github-actions bot removed the acceptance: go ahead Reviewed, implementation can start label Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@V0ldek V0ldek

Labels
area: library Improvements to the library API quality type: feature New feature or request type: reliability Tests, code quality
Projects
Active rq development
Status: Released
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

Panic-free engine execution rsonquery/rsonpath
1 participant
@V0ldek