Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse the index selector (non-negative) #60

Closed
V0ldek opened this issue Nov 26, 2022 · 1 comment · Fixed by #128
Closed

Parse the index selector (non-negative) #60

V0ldek opened this issue Nov 26, 2022 · 1 comment · Fixed by #128
Assignees
@zwerdlds
Labels
area: selector Support for a JSONPath selector good first issue Good for newcomers help wanted External contributions welcome type: feature New feature or request
Milestone
v1.0.0

Comments

@V0ldek
Copy link
Member

V0ldek commented Nov 26, 2022 •
edited
Loading

Is your feature request related to a problem? Please describe.
As the first step in introducing the index selector (#64, TODO), we need to add support in the parser.

Describe the solution you'd like
This is straightforward, a new JsonPathQueryNode that will hold the index. Additionally, we need good error messages:

  1. If given a negative number, tell the user this is not supported yet, linking to TODO.
  2. If given something else than a valid number, tell the user that they might be looking for the normal member selector but missed quotation marks.

Additional context
Syntax formulation in the RFS.
@V0ldek V0ldek added type: feature New feature or request help wanted External contributions welcome good first issue Good for newcomers mod: parser area: selector Support for a JSONPath selector labels Nov 26, 2022
@V0ldek V0ldek changed the title Parse the index selector (positive) Parse the index selector (non-negative) Nov 26, 2022
@github-actions github-actions bot added the acceptance: triage Waiting for owner's input label Nov 26, 2022
@github-actions
Copy link

Tagging @V0ldek for notifications

@V0ldek V0ldek added this to the v1.0.0 milestone Nov 26, 2022
@github-actions github-actions bot added acceptance: go ahead Reviewed, implementation can start and removed acceptance: triage Waiting for owner's input labels Nov 26, 2022
@V0ldek V0ldek mentioned this issue Nov 26, 2022
Closed
This was referenced Dec 3, 2022
Closed
Closed
@zwerdlds zwerdlds self-assigned this Apr 20, 2023
@zwerdlds zwerdlds mentioned this issue Apr 28, 2023
Merged
3 tasks
V0ldek added a commit that referenced this issue May 4, 2023
@zwerdlds @V0ldek
feat: parser support for array index selector
6b859b5 
Parser now recognizes the array index selector with positive index values conforming to the I-JSON specification.

Ref: #60

Co-authored-by: V0ldek <mat@gienieczko.com>
@github-actions github-actions bot removed the acceptance: go ahead Reviewed, implementation can start label May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zwerdlds zwerdlds

Labels
area: selector Support for a JSONPath selector good first issue Good for newcomers help wanted External contributions welcome type: feature New feature or request
Projects
Active rq development
Status: Released
Milestone
v1.0.0
2 participants
@zwerdlds @V0ldek