Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install is broken #86

Closed
V0ldek opened this issue Jan 25, 2023 · 1 comment · Fixed by #87
Closed

Install is broken #86

V0ldek opened this issue Jan 25, 2023 · 1 comment · Fixed by #87
Labels
area: app Improvements in overall CLI app usability type: bug Something isn't working
Milestone
v1.0.0

Comments

@V0ldek
Copy link
Member

V0ldek commented Jan 25, 2023

Describe the bug
Installing rsonpath on Ubuntu on a platform supporting AVX2 fails to install by saying AVX2 is not supported.

image

MRE
Run cargo install rsonpath.

Expected behavior

  1. rsonpath installs with AVX2 support enabled.
  2. The error should include the link to the bug report issue, not just the repo: https://github.com/V0ldek/rsonpath/issues/new?template=bug_report.md
  3. This should be caught in CI/CD, not a week later randomly by me installing the binary.

Workarounds (optional)
You can pass `RUSTFLAGS="-C target-cpu=native" and then it installs correctly.

Desktop (please complete the following information):

  • Rust version: 1.66.1
  • Target triple: x86_64-unknown-linux-gnu
  • Features: default
  • Version: v0.2.0
@V0ldek V0ldek added the type: bug Something isn't working label Jan 25, 2023
@github-actions github-actions bot added the acceptance: triage Waiting for owner's input label Jan 25, 2023
@github-actions
Copy link

Tagging @V0ldek for notifications

@V0ldek V0ldek added this to the v1.0.0 milestone Jan 25, 2023
@github-actions github-actions bot added acceptance: go ahead Reviewed, implementation can start and removed acceptance: triage Waiting for owner's input labels Jan 25, 2023
@V0ldek V0ldek added acceptance: triage Waiting for owner's input area: app Improvements in overall CLI app usability acceptance: go ahead Reviewed, implementation can start and removed acceptance: go ahead Reviewed, implementation can start acceptance: triage Waiting for owner's input labels Jan 25, 2023
@V0ldek V0ldek mentioned this issue Jan 25, 2023
Merged
@github-actions github-actions bot removed the acceptance: go ahead Reviewed, implementation can start label Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: app Improvements in overall CLI app usability type: bug Something isn't working
Projects
Active rq development
Status: Released
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

Fix install rsonquery/rsonpath
1 participant
@V0ldek