Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move python GCD code from euclidean distance to GCD. #858

Closed
wants to merge 1 commit into from
Closed

Move python GCD code from euclidean distance to GCD. #858

wants to merge 1 commit into from

Conversation

Anupam-dagar
Copy link

Fixes: #785

@Anupam-dagar
Copy link
Author

Anupam-dagar commented Dec 23, 2018

HI @ravivarshney01, can you tell me why it was closed rather than being merged?

@ravivarshney01
Copy link
Member

@i-vishi is already working on this and you have moved only one file

@Anupam-dagar
Copy link
Author

Anupam-dagar commented Dec 23, 2018

The issue is open from around 2 months and involves moving just 2 files. Also if you can review the PR properly, you may see that I have moved both the files. There wasn't any significant progress by any of the contributor and hence I submitted a PR. Also you just assigned yourself and @i-vishi on the issue.
This just seems totally wrong on the part of closing the PR when the fix is totally correct. 😄

@ravivarshney01
Copy link
Member

@Anupam-dagar in actual scenario many files are wrongly placed and we are working on this...

@Anupam-dagar
Copy link
Author

I just did what the issue said. I think its better to close down the issue and not even fund it for the same.
Thanks for the clarification though.

@ravivarshney01
Copy link
Member

and if you are looking for issue hunt then create an issue and i will request that issue for reward.😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants