Departure release features #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AxonC
reviewed
Jul 1, 2021
|
|
||
| bool DepartureReleaseEventHandler::DepartureReleaseRequestedMessageValid(const nlohmann::json& data) const | ||
| { | ||
| return data.is_object() && |
There was a problem hiding this comment.
This might be slightly more readable if you kind of split it into:#
- contains checks
- type checks
And then just return an and on those two?
AxonC
approved these changes
Jul 1, 2021
…ntroller-plugin into departure-release-features
AndyTWF
added a commit
that referenced
this pull request
Jul 2, 2021
* feat(curl): Include User Agent In cURL * feat(graphics): Add standard graphics components (#267) * feat(graphics): Add standard graphics components * Add system clock and timer displays * Add To Project * Move To Right Project * Add Missing Matchers * feat(controllers): Implement controller positions V2 dependency (#268) * feat(controllers): Implement controller positions V2 dependency * Add Missing Change * test(misc): Bring across changes from more tests * feat(releases): Add API calls for departure releases (#269) * feat(euroscope): Add additional EuroScope interfaces (#271) * feat(euroscope): Add additional EuroScope interfaces * Update Base Plugin * Departure release features (#281) * Add departure release docs * Departure release resources * Update Release Module Bootstrap * Merge in release bits * Add Missing Override * Add Missing Solution Items * Fix linting * Change Wording
VATSIMUK
pushed a commit
that referenced
this pull request
Jul 2, 2021
# [3.1.0](3.0.1...3.1.0) (2021-07-02) ### Bug Fixes * **semantic-release:** add missing semantic release plugins ([d9f7851](d9f7851)) ### Features * **releases:** Add electronic departure releases ([#272](#272)) ([9754ad5](9754ad5)), closes [#267](#267) [#268](#268) [#269](#269) [#271](#271) [#281](#281)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.